Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit on first error on the esp32 qemu tests script #1328

Merged
merged 2 commits into from
Jun 30, 2020
Merged

Exit on first error on the esp32 qemu tests script #1328

merged 2 commits into from
Jun 30, 2020

Conversation

vivien-apple
Copy link
Contributor

Problem

While the Qemu tests runs, if the build fails the scripts continue to try to run a bunch of tests.
This is misleading as one may end up thinking that some tests are broken but the the rest is fine while nothing has been built (and it also waste some time on the CI side).

Summary of Changes

  • add 'set -e' to exit on the first error

gerickson
gerickson suggested changes Jun 29, 2020
View reviewed changes
scripts/tests/esp32_qemu_tests.sh Outdated Show resolved Hide resolved
@vivien-apple vivien-apple force-pushed the Tests_QemuExitOnError branch from bc6e108 to 4ebc769 Compare June 29, 2020 14:51
@restyled-io restyled-io bot mentioned this pull request Jun 29, 2020
Closed
@vivien-apple vivien-apple requested a review from gerickson June 29, 2020 14:52
@vivien-apple vivien-apple force-pushed the Tests_QemuExitOnError branch from 4ebc769 to 40f51c5 Compare June 29, 2020 14:53
@vivien-apple vivien-apple force-pushed the Tests_QemuExitOnError branch from 40f51c5 to 3dc6397 Compare June 29, 2020 14:54
@chip-bot
Copy link

Size increase report for "Build Examples [ESP32]"

File Section File VM
chip-wifi-echo.elf .flash.text 12 12
chip-wifi-echo.elf .dram0.bss 0 -8
Full report output 
Bloat report for job 'Build Examples [ESP32]'

Files found only in the baseline:
    bloat_report.txt

Comparing master_binaries/esp32-build/chip-wifi-echo.elf and example_binaries/esp32-build/chip-wifi-echo.elf:

sections,vmsize,filesize
.flash.text,12,12
[Unmapped],0,-4
.dram0.bss,-8,0

@chip-bot
Copy link

Size increase report for "Build Examples [nRF]"

File Section File VM
Full report output 
Bloat report for job 'Build Examples [nRF]'

Files found only in the baseline:
    bloat_report.txt

Comparing master_binaries/nrf-build/chip-nrf52840-lock-example.out and example_binaries/nrf-build/chip-nrf52840-lock-example.out:

sections,vmsize,filesize

@chip-bot
Copy link

Size increase report for "Build Examples [main-build]"

File Section File VM
Full report output 
Bloat report for job 'Build Examples [main-build]'

Files found only in the baseline:
    bloat_report.txt

Comparing master_binaries/main-build/chip-standalone-demo.out and example_binaries/main-build/chip-standalone-demo.out:

sections,vmsize,filesize

@woody-apple
Copy link
Contributor

@jelderton @andy31415 ?

@andy31415
Copy link
Contributor

@gerickson are the updates addressing your 'changes requested' flag?

@woody-apple woody-apple merged commit f2bc3f1 into project-chip:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@saurabhst saurabhst saurabhst approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@BroderickCarlin BroderickCarlin Awaiting requested review from BroderickCarlin

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@gerickson gerickson Awaiting requested review from gerickson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vivien-apple @chip-bot @woody-apple @andy31415 @gerickson @saurabhst @terafin